Messages in this thread | | | Date | Tue, 8 Feb 2005 15:43:26 -0800 | From | Chris Wright <> | Subject | Re: [PATCH] BSD Secure Levels: nits, 2.6.11-rc2-mm1 (6/8) |
| |
* Michael Halcrow (mhalcrow@us.ibm.com) wrote: > This is the sixth in a series of eight patches to the BSD Secure > Levels LSM. It makes several trivial changes to make the code > consistent.
These are inconsistent with CodingStyle. I'd drop this, and go the other way (patch is smaller) ala Lindent.
> struct seclvl_obj { > - char *name; > + char * name;
This is opposite of typical style.
> -seclvl_attr_store(struct kobject *kobj, > - struct attribute *attr, const char *buf, size_t len) > +seclvl_attr_store(struct kobject * kobj, > + struct attribute * attr, const char * buf, size_t len)
same here...etc.
Lindent nearly undoes all these changes. If we're going to reformat code, I'd prefer to see it done via Lindent.
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |