Messages in this thread | | | From | Tom Zanussi <> | Date | Fri, 4 Feb 2005 16:06:58 -0600 | Subject | Re: [PATCH] relayfs redux, part 3 |
| |
Christoph Hellwig writes: > in the filesystem path especially relayfs_create_entry and the functions > called by it seem overly complex, probably because copying from ramfs > which allows namespace operations from userland. See the totally untested > code below for how it could be done more cleanly.
Thanks, I'll do some simplification as you suggest.
> > What I really dislike is the code for automatically creating complex > hiearchies. What kinds of hierachies does LTT use? It shouldn't be > more than subsystem/{stream1, stream2, ..., streamN}, right? In that > case I think we could leave it to the user to take of that himself. >
Yeah, I was debating whether to keep that code or just export a creat_subdir() function instead, which I think I'll do after all. ltt doesn't really doesn't need much of a hierarchy beyond ltt/ or maybe one more deep e.g. ltt/trace ltt/flight, and I doubt many other applications would either.
Tom
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |