lkml.org 
[lkml]   [2005]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] relayfs redux, part 3
Christoph Hellwig writes:
> in the filesystem path especially relayfs_create_entry and the functions
> called by it seem overly complex, probably because copying from ramfs
> which allows namespace operations from userland. See the totally untested
> code below for how it could be done more cleanly.

Thanks, I'll do some simplification as you suggest.

>
> What I really dislike is the code for automatically creating complex
> hiearchies. What kinds of hierachies does LTT use? It shouldn't be
> more than subsystem/{stream1, stream2, ..., streamN}, right? In that
> case I think we could leave it to the user to take of that himself.
>

Yeah, I was debating whether to keep that code or just export a
creat_subdir() function instead, which I think I'll do after all. ltt
doesn't really doesn't need much of a hierarchy beyond ltt/ or maybe
one more deep e.g. ltt/trace ltt/flight, and I doubt many other
applications would either.

Tom


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.068 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site