lkml.org 
[lkml]   [2005]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.10 Kernel BUG at hugetlbpage:212 (x86_64 and i386)
On Fri, Feb 04, 2005 at 04:39:02PM +0000, Hugh Dickins wrote:
> Patch below (against 2.6.11-rc3, applies at offset to 2.6.10) fixes
> the unmap_hugepage_range BUGs I could generate: does it fix yours?
> The hugetlb_page test in do_munmap is too permissive. It checks start
> vma, but forgets that end vma might be different and huge though start
> is not: so hits unmap_hugepage_range BUG if misaligned end was given.
> And it's too restrictive: munmap has always succeeded on unmapped areas
> within its range, why should it behave differently near a hugepage vma?
> And the additional checks in is_aligned_hugepage_range are irrelevant
> here, when the hugepage vma already exists. But the function is still
> required (on some arches), as the default for prepare_hugepage_range -
> leave renaming cleanup to another occasion.
> Signed-off-by: Hugh Dickins <hugh@veritas.com>

As usual, excellent work. Thanks for fixing this up.

Acked-by: William Irwin <wli@holomorphy.com>


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.045 / U:1.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site