lkml.org 
[lkml]   [2005]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.11-rc2 05/29] ide: merge pci driver .h's into .c's
On Wed, 2 Feb 2005 11:47:12 +0900, Tejun Heo <tj@home-tj.org> wrote:
> > 05_ide_merge_pci_driver_hc.patch
> >
> > Merges drivers/ide/pci/*.h files into their corresponding *.c
> > files. Rationales are
> > 1. There's no reason to separate pci drivers into header and
> > body. No header file is shared and they're simple enough.
> > 2. struct pde_pci_device_t *_chipsets[] are _defined_ in the
> > header files. That isn't the custom and there's no good
> > reason to do differently in these drivers.
> > 3. Tracking changelogs shows that the bugs fixed by 00 and 01
> > are introduced during mass-updating ide pci drivers by
> > forgetting to update *.h files.
>
> Signed-off-by: Tejun Heo <tj@home-tj.org>

Please kill crap in these .h files before mering them with .c files,
also split this patch on per driver changes.

crap example looks like this: ;)

> +#ifndef SPLIT_BYTE
> +#define SPLIT_BYTE(B,H,L) ((H)=(B>>4), (L)=(B-((B>>4)<<4)))
> +#endif
> +#ifndef MAKE_WORD
> +#define MAKE_WORD(W,HB,LB) ((W)=((HB<<8)+LB))
> +#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.350 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site