Messages in this thread Patch in this message | | | Date | Thu, 3 Feb 2005 21:29:43 +0100 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: via82cxxx resume failure. |
| |
Sorry for the delay.
On Mon, 17 Jan 2005 09:25:30 +0000, David Woodhouse <dwmw2@infradead.org> wrote: > On resume from sleep, via_set_speed() doesn't reinstate the correct DMA > mode, because it thinks the drive is already configured correctly. This > one-line hack is sufficient to make it refrain from dying a horrible > death immediately after resume, but presumably has other problems...
I applied this to libata-dev so it gets some testing in -mm.
> ===== drivers/ide/pci/via82cxxx.c 1.24 vs edited ===== > --- 1.24/drivers/ide/pci/via82cxxx.c Mon Aug 9 18:00:46 2004 > +++ edited/drivers/ide/pci/via82cxxx.c Tue Oct 26 22:48:59 2004 > @@ -328,7 +328,7 @@ > struct ide_timing t, p; > unsigned int T, UT; > > - if (speed != XFER_PIO_SLOW && speed != drive->current_speed) > + // if (speed != XFER_PIO_SLOW && speed != drive->current_speed) > if (ide_config_drive_speed(drive, speed)) > printk(KERN_WARNING "ide%d: Drive %d didn't " > "accept speed setting. Oh, well.\n", > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |