Messages in this thread | | | Date | Mon, 28 Feb 2005 09:06:50 -0500 | From | Dmitry Torokhov <> | Subject | Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code |
| |
On Mon, 28 Feb 2005 15:02:32 +0100, Arjan van de Ven <arjan@infradead.org> wrote: > \ > > > >> + for(npar = NPAR-1; npar < NPAR; npar--) > > > > > > >How many times do you want this for loop to run? > > > > > > NPAR times :-). As I stated, npar is unsigned. > > > > > > > for (npar = NPAR - 1; npar >= 0; npar--) > > > > would be more readable and may be even faster on a dumb compiler than > > your variant. Still, I'd have compiler worry about such > > micro-optimizations. > > actually that goes wrong for npar unsigned... > >
Oops, you are right...
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |