Messages in this thread | | | Date | Mon, 28 Feb 2005 22:53:55 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups |
| |
On Mon, Feb 28, 2005 at 09:29:20PM +0000, Christoph Hellwig wrote: > On Mon, Feb 28, 2005 at 10:00:24PM +0100, Adrian Bunk wrote: > > This patch contains the following cleanups: > > - make needlessly global code static > > - kill the unused global *_version and *_version_str variables > > in the firmware files > > The firmware files are generated, so it'd be better to leave them > alone.
Agreed.
But can't the generation of these files omit these needless variables (there are already #define's containing the version information)?
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |