Messages in this thread | | | Date | Sun, 27 Feb 2005 15:53:48 +0900 | Subject | Re: [PATCH 2.6.11-rc3 10/11] ide: make ide_cmd_ioctl() use TASKFILE | From | Tejun Heo <> |
| |
Hello, Bartlomiej.
On Thu, Feb 24, 2005 at 04:50:39PM +0100, Bartlomiej Zolnierkiewicz wrote: > > + in_valid->b.status_command = 1; > > + in_valid->b.error_feature = 1; > > + in_valid->b.nsector = 1; > > ide_end_drive_cmd() must be fixed first to respect ->tf_in_flags > and it must be done *without* affecting HDIO_DRIVE_TASKFILE.
Hmmm... does it make any difference other than reading more registers? Are you worried about performance impacts? Is there hardware which acts differently if more registers are read?
> > > extern int ide_driveid_update(ide_drive_t *); > > -extern int ide_ata66_check(ide_drive_t *, ide_task_t *); > > +int ide_ata66_check(ide_drive_t *, ide_task_t *); > > extern int ide_config_drive_speed(ide_drive_t *, u8); > > extern u8 eighty_ninty_three (ide_drive_t *); > > -extern int set_transfer(ide_drive_t *, ide_task_t *); > > +int set_transfer(ide_drive_t *, ide_task_t *); > > extern int taskfile_lib_get_identify(ide_drive_t *drive, u8 *); > > leftovers from previous version of the patch
Yeah, sorry.
Thanks.
-- tejun
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |