Messages in this thread | | | Date | Mon, 28 Feb 2005 03:22:20 +0000 | From | Christoph Hellwig <> | Subject | Re: [ patch 6/7] drivers/serial/jsm: new serial device driver |
| |
On Sun, Feb 27, 2005 at 07:47:58PM -0500, Jeff Garzik wrote: > >+struct shrink_buf_struct { > >+ unsigned int shrink_buf_vaddr; /* Virtual address of board > >*/ > >+ unsigned int shrink_buf_phys; /* Physical address of board > >*/ > > Major bug. These should be unsigned long.
not sure what they actually mean, but a virtual address should be a void * and drivers shouldn't ever mess with physical addresses.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |