Messages in this thread | | | Date | Thu, 24 Feb 2005 20:28:10 -0800 | From | William Lee Irwin III <> | Subject | Re: [PPC64] Hugepage hash flushing bugfix |
| |
On Fri, Feb 25, 2005 at 03:14:46PM +1100, David Gibson wrote: > Andrew, Linus, please apply: > Fix a potentially bad (although very rarely triggered) bug in the > ppc64 hugepage code. hpte_update() did not correctly calculate the > address for hugepages, so pte_clear() (which we use for hugepage ptes > as well as normal ones) would not correctly flush the hash page table > entry. Under the right circumstances this could potentially lead to > duplicate hash entries, which is very bad. > davem's upcoming patch to pass the virtual address directly to > set_pte() and its ilk will obsolete this, but this is bad enough it > should probably be fixed in the meantime. > Signed-off-by: David Gibson <dwg@au1.ibm.com>
Very clear explanation. I second the motion for a rapid merge.
Acked-by: William Irwin <wli@holomorphy.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |