Messages in this thread | | | Date | Thu, 24 Feb 2005 10:47:05 -0500 | From | Ryan Anderson <> | Subject | Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector |
| |
On Thu, Feb 24, 2005 at 02:46:05AM -0800, Andrew Morton wrote: > Guillaume Thouvenin <guillaume.thouvenin@bull.net> wrote: > > > +spinlock_t fork_cn_lock = SPIN_LOCK_UNLOCKED; > > This should have static scope, and could be local to fork_connector(). > > Please use DEFINE_SPINLOCK(). (There's a reason for this, but I forget > what it was).
Static analysis tools, IIRC. (Stanford checker, sparse)
--
Ryan Anderson sometimes Pug Majere - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |