Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 2 Feb 2005 18:46:00 -0500 (EST) | From | James Morris <> | Subject | Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm |
| |
On Thu, 3 Feb 2005, Fruhwirth Clemens wrote:
> > > +static int ecb_process_gw(void *_priv, int nsg, void **buf) > > > What does _gw mean? > > generic walker.. can be removed, if you like.
That's fine, was just wondering.
> > > + r = pf(priv, nsl, dispatch_list); > > > + if(unlikely(r < 0)) > > > + goto out; > > > > Not sure if the unlikely() is justified here, given that this is not a > > fast path. I guess it doesn't do any harm. > > I suspected unlikely to be a hint for the compiler to do better jump > prediction and speculations. Remove?
Correct, although I think this will get lost in the noise given that it's sitting in the middle of crypto processing. I'd remove it.
- James -- James Morris <jmorris@redhat.com>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |