lkml.org 
[lkml]   [2005]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Consolidate compat_sys_waitid
    On Tue, Feb 15, 2005 at 10:06:14PM +1100, Stephen Rothwell wrote:
    > Hi Andi,
    >
    > On Tue, 15 Feb 2005 10:51:53 +0100 Andi Kleen <ak@suse.de> wrote:
    > >
    > > I don't think this will work for sparc64/s390/UML etc.
    > > They cannot access kernel data inside KERNEL_DS. You would need to use
    > > compat_alloc_user_space() for ru
    >
    > .. and, presumably, for info as well. Interestingly, this code
    > came directly from sparc64 ...

    Sorry, I misread the code. In this case it's actually ok.

    The only thing that doesn't work is mixing the pointers (e.g. accessing
    user mode pointers inside KERNEL_DS)

    So the patch is fine.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:4.443 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site