Messages in this thread | | | Subject | Re: [PATCH] ext3: Fix sparse -Wbitwise warnings. | From | "Stephen C. Tweedie" <> | Date | Tue, 15 Feb 2005 23:25:53 +0000 |
| |
Hi,
On Tue, 2005-02-15 at 23:29, Mitchell Blank Jr wrote:
> Of course that's less efficient though since "mask" is probably constant.. > so now the endian conversion changed from compile-time to run-time. > > Would something like > > ( ( EXT3_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask) ) != 0) > > be enough to satisfy sparse?
Yes, but it breaks other places: there are a few places where callers actually want the real return value from the "&", so that (for example) they can tell the user which feature failed the compatibility test.
--Stephen
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |