Messages in this thread | | | Date | Fri, 7 Jan 2005 21:07:29 -0800 | From | Greg KH <> | Subject | Re: [RFC/PATCH] add support for sysdev class attributes |
| |
On Fri, Jan 07, 2005 at 04:28:12PM -0600, Nathan Lynch wrote: > @@ -88,6 +123,12 @@ int sysdev_class_register(struct sysdev_ > INIT_LIST_HEAD(&cls->drivers); > cls->kset.subsys = &system_subsys; > kset_set_kset_s(cls, system_subsys); > + > + /* I'm not going to claim to understand this; see > + * fs/sysfs/file::check_perm for how sysfs_ops are selected > + */ > + cls->kset.kobj.ktype = &sysdev_class_ktype; > +
I think you need to understand this, and then submit a patch without such a comment :)
And probably without such code, as I don't think you need to do that.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |