Messages in this thread | | | Date | Sun, 9 Jan 2005 00:33:33 +0100 | From | Alessandro Suardi <> | Subject | Re: [PATCH] USB and Driver Core patches for 2.6.10 |
| |
On Sat, 8 Jan 2005 14:42:32 -0800, Greg KH <greg@kroah.com> wrote: > On Sat, Jan 08, 2005 at 12:08:58PM +0000, Christoph Hellwig wrote: > > On Fri, Jan 07, 2005 at 09:47:43PM -0800, Greg KH wrote: > > > ChangeSet 1.1938.444.33, 2004/12/22 13:50:21-08:00, davej@redhat.com > > > > > > [PATCH] driver core: Fix up vesafb failure probing. > > > > > > bus.c file invokes a probe callback for most devices in a list, then checks > > > for -ENODEV return ("no such device"), if so it remains silent. However, some > > > drivers (including vesafb.c) may return -ENXIO ("no such device or address"), > > > which is indeed error -6. > > > > > > I shut up the warning with the attached patch, that basically ignores > > > both -ENODEV and -ENXIO. > > > > NAK. We shouldn't have two return codes indicating the same error (or > > actually non-error in this case). Let's fix the drivers instead. > > Ok, David, care to send a patch to do so?
The above would be the patch I posted here
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=125890
the reason I went for the lazy approach is mainly that I tried to look into the usage of -ENXIO vs -ENODEV, but just grepping in drivers/video/*.c turned out to be confusing rather than enlightening... should *all* -ENXIO be converted into -ENODEV ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |