Messages in this thread | | | Date | Fri, 7 Jan 2005 12:02:13 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: From last __GFP_ZERO changes |
| |
On Fri, 7 Jan 2005, Martin Hicks wrote:
> > On Thu, Jan 06, 2005 at 12:43:58PM +0100, Marco Cipullo wrote: > > From last __GFP_ZERO changes: > > > > --- a/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00 > > +++ b/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00 > > @@ -135,12 +135,10 @@ > > goto no_bio; > > > > for (i = 0; i < PAGES_PER_PACKET; i++) { > > - pkt->pages[i] = alloc_page(GFP_KERNEL); > > + pkt->pages[i] = alloc_page(GFP_KERNEL|| __GFP_ZERO); > > > > Is this OK? > > > > Or should be > > > > for (i = 0; i < PAGES_PER_PACKET; i++) { > > - pkt->pages[i] = alloc_page(GFP_KERNEL); > > + pkt->pages[i] = alloc_page(GFP_KERNEL| __GFP_ZERO); > > It definitely should be the latter.
Correct. Please submit the patch. I see a patch that fixes a pktcdvd.c issue in Andrews tree so it was likely already fixed without me hearing of it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |