Messages in this thread | | | Date | Thu, 6 Jan 2005 09:47:08 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: Prezeroing V3 [2/4]: Extension of clear_page to take an order parameter |
| |
On Thu, 6 Jan 2005, Andi Kleen wrote:
> Christoph Lameter <clameter@sgi.com> writes: > > > Here is an updated version that is independent of the first patch and > > contains all the necessary modifications to make clear_page take a second > > parameter. > > I still think the clear_page order addition is completely pointless, > because for > order 0 you probably want a cache bypassing store > in a separate function.
I would think that having clear_page avoid loading cache lines from memory should be general improvement.
Bypassing the cache may be beneficial for clear_page in general but I would like to test that first.
If this is not a win then it may be better to implement the bypassing the cache through a zero driver.
> Removing it would also make the patch much less intrusive.
Right. I also thought about that. I will likely offer the clear_page patch as an optional component in V4. Being able to specify an order with clear_page also helps in other situations like clearing huge pages.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |