Messages in this thread | | | Subject | Re: [2.6.10-bk7] Oops: ide_dma_timeout_retry | From | Alan Cox <> | Date | Thu, 06 Jan 2005 16:30:14 +0000 |
| |
On Mer, 2005-01-05 at 23:33, Simon Kirby wrote: > I added the usual test for NULL, printk, goto out, and the machine > continues without visibly exploding when this case occurs. Is the > correct fix or is it expected that rq should never be NULL?
The initial UncorrectableError is the drive erroring the request due to real failure of the drive to get the data. There are some races in the base code when that occurs
rq should never be NULL at that point because after all there has to be a request which has timed out. If the timeout isn't being cleared on the error path that would make sense of the trace or if the timeout occurred at the same time as the error completed it would have raced.
It could also be due to the fact base 2.6.10 will corrupt requests on errors sometimes (which SGI now fixed)
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |