Messages in this thread | | | Date | Thu, 6 Jan 2005 16:09:42 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] macros to detect existance of unlocked_ioctl and ioctl_compat |
| |
On Thu, Jan 06, 2005 at 02:53:56PM +0000, Christoph Hellwig wrote: > On Thu, Jan 06, 2005 at 04:06:36PM +0200, Michael S. Tsirkin wrote: > > > It should be, unless there's some problem. In maybe a week or so. > > > > To make life bearable for out-of kernel modules, the following patch > > adds 2 macros so that existance of unlocked_ioctl and ioctl_compat > > can be easily detected. > > That's not the way we're making additions. Get your code merged and > there won't be any need to detect the feature.
I would agree that it shouldn't be used for in tree code, but for out of tree code it is rather useful. There are other such feature macros for major driver interface changes too (e.g. in the network stack).
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |