Messages in this thread | | | From | Roman Zippel <> | Subject | Re: [patch] pedantic correctness cleanup for conf.c in scripts/kconfig/ . | Date | Wed, 5 Jan 2005 13:26:55 +0100 |
| |
Hi,
On Tuesday 04 January 2005 00:35, Jesper Juhl wrote:
> @@ -305,8 +305,8 @@ static int conf_choice(struct menu *menu > printf("%*s%s\n", indent - 1, "", menu_get_prompt(menu)); > def_sym = sym_get_choice_value(sym); > cnt = def = 0; > - line[0] = '0'; > - line[1] = 0; > + line[0] = '\0'; > + line[1] = '\0'; > for (child = menu->list; child; child = child->next) { > if (!menu_is_visible(child)) > continue;
This would make a difference and even the other change is not an improvement, 0 is special string marker and not a character.
bye, Roman
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |