lkml.org 
[lkml]   [2005]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch] pedantic correctness cleanup for conf.c in scripts/kconfig/ .
Date
Hi,

On Tuesday 04 January 2005 00:35, Jesper Juhl wrote:

> @@ -305,8 +305,8 @@ static int conf_choice(struct menu *menu
> printf("%*s%s\n", indent - 1, "", menu_get_prompt(menu));
> def_sym = sym_get_choice_value(sym);
> cnt = def = 0;
> - line[0] = '0';
> - line[1] = 0;
> + line[0] = '\0';
> + line[1] = '\0';
> for (child = menu->list; child; child = child->next) {
> if (!menu_is_visible(child))
> continue;

This would make a difference and even the other change is not an improvement,
0 is special string marker and not a character.

bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.356 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site