Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] Fix SERIAL_TXX9 dependencies | Date | Sun, 30 Jan 2005 16:45:08 +0100 |
| |
On Sünndag 30 Januar 2005 14:05, Atsushi Nemoto wrote: > >>>>> On Sun, 30 Jan 2005 00:15:55 +0000, Ralf Baechle <ralf@linux-mips.org> said: > ralf> Ask for SERIAL_TXX9 only on those devices that actually have > ralf> one. > > Well, "depends on MIPS || PCI" was intentional. The driver can be > used for both TX39/TX49 internal SIO and TC86C001 PCI chip. TC86C001 > chip can be available for any platform with PCI bus (though I have > never seen it on platform other than MIPS ...)
There is at least one device that uses the same uart on a non-MIPS platform. I'll submit a patch once I have it working.
> So I suppose "depends on HAS_TXX9_SERIAL || PCI" might be better, but > Ralf's patch will be OK for now.
Right. There is however one bigger problem with the original patch: It removes the driver for tx3912 and adds one for tx3927/tx49xx. AFAICS, the 3912 has a very different register layout from the other chips, so the old driver must not be removed yet.
Arnd <>< [unhandled content-type:application/pgp-signature] | |