Messages in this thread | | | Date | Sat, 29 Jan 2005 17:27:46 +0100 | From | Pierre Ossman <> | Subject | Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA |
| |
Christoph Hellwig wrote:
>On Sat, Jan 29, 2005 at 05:08:32PM +0100, Pierre Ossman wrote: > > >>For i386 and x86_64 it's defined as virt_to_phys in asm/io.h without any >>#ifdef:s protecting it. >> >> > >Not all the world is a PC > > > Then the dependency should in that case be on architectures. It is connected similar to a floppy (which is not dependent on ISA and uses isa_virt_to_bus).
The point is that isa_virt_to_bus() is the method used by devices connected in the same way. This works on the platforms where the device can be found (i386 and x86_64). We can not make it dependent on ISA since you cannot enable ISA on all platforms where it exists (i.e. x86_64). Either fix that or make the driver depend on architecture the same way floppy does.
Using the generic DMA API might be a viable option now that x86_64 seems to be fixed. But it doesn't have a good track record so I'm not prepared to commit any changes until I have time to properly test it. There might still be assumptions about PCI lurking around.
Rgds Pierre - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |