Messages in this thread | | | Date | Sat, 29 Jan 2005 00:58:20 -0500 | From | Christopher Li <> | Subject | [PATCH] compat USB ioctl take II was Re: compat ioctl for submiting URB |
| |
On Sat, Jan 29, 2005 at 07:33:31AM +0100, Andi Kleen wrote: > Issues: > - Should use CONFIG_COMPAT, not x86-64 specific symbols Fixed.
> - Why can't you set URB_COMPAT transparently in the emulation > layer? Then existing applications would hopefully work without > changes, right?
Now I see it. That is not what I intent. I must misplace it. I remove the USB_COMPAT in the new patch any way. It looks cleaner.
> You may also want to preserve the __user casts, otherwise
Not sure where it is. But I need to verify this patch on Monday. I don't have an AMD 64 at home.
Thanks.
Chris
| |