Messages in this thread | | | Subject | Re: [patch 0/3] kallsyms: Add gate page and all symbols support | From | Benjamin Herrenschmidt <> | Date | Tue, 18 Jan 2005 18:52:55 +1100 |
| |
On Tue, 2004-12-28 at 22:17 +0100, Sam Ravnborg wrote:
> > 2 Add in_gate_area_no_task() for use from places where no task is valid.
Can you back that out ? Or at least explain why you need to add this "no_task" thing and not just use "current" where no task is available ? I think the above is bogus for 3 reasons:
- I tend to dislike adding functions "foo_with_that_parameter_instead_of_that" ... We do it here or there, but the less we do it, the happier I am :)
- Since you unconditionally #define in_gate_area() to use in_gate_area_no_task(), what is the point of having in_gate_area() at all ? Which rather means, what is the point of adding that "_no_task" version and not just change in_gate_area to not take a task ?
- I dislike the fact that you now define the prototype of the function in the __HAVE_ARCH_GATE_AREA case. I want my arch .h to be the one doing so, since i want to inline it (to nothing in the ppc64 case since the vDSO I'm implementing doesn't need any special treatement of the gate area, it's a normal VMA added to the mm's at exec time).
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |