Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 2/3] switch frw to use local_soft_irq_pending | Date | Mon, 17 Jan 2005 12:14:37 +0000 |
| |
Christoph Hellwig <hch@lst.de> wrote:
> The newly merged frv do_IRQ code calls softirq_pending(), but always with > the current cpu as argument - switch to local_softirq_pending(). > > Btw, this usage look bogus to me, any reason you need to call do_softirq > again after you did four lines above in irq_exit(), David?
Because irq_exit() doesn't call do_softirq() in 2.4 where I developed this arch in the first place. And because 2.6 didn't malfunction due to do_softirq() being called twice, I didn't notice.
Actually... it's probably also bad that it calls irq_exit() first and then __clr_MASK(). That means it runs softirq processing with at least one interrupt level disabled:-/
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |