Messages in this thread | | | Date | Mon, 17 Jan 2005 10:53:19 -0800 | From | Chris Wedgwood <> | Subject | Re: [PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id() |
| |
On Mon, Jan 17, 2005 at 03:40:16PM +0100, Ingo Molnar wrote:
> no ... normally you should only use __get_cpu_var() if you know that > you are in a non-preempt case. It's a __ internal function for a > reason. Where did it trigger?
XFS has statistics which are 'per cpu' but doesn't use per_cpu variables, __get_cpu_var(foo)++ is used (it doesn't have to be preempt safe since it's just stats and who cares if they are a bit wrong). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |