Messages in this thread | | | Date | Thu, 9 Sep 2004 12:23:13 -0700 | From | William Lee Irwin III <> | Subject | Re: [1/1][PATCH] nproc v2: netlink access to /proc information |
| |
On Thu, 09 Sep 2004 11:49:33 -0700, William Lee Irwin III wrote: >> I'll follow up shortly with a task_mem()/task_mem_cheap() consolidation >> patch atop the others I sent.
On Thu, Sep 09, 2004 at 09:11:42PM +0200, Roger Luethi wrote: > I have a few minor changes coming up as well.
I rest assured that nothing I've written thus far will apply to or be included in any of it, as a matter of course (nothing specific to you).
On Thu, Sep 09, 2004 at 09:11:42PM +0200, Roger Luethi wrote: > One nitpick: As vmexe and vmlib are always 0 for !CONFIG_MMU, we should > ifdef them out of the list of offered fields for that configuration (and > maybe in nproc_ps_field as well).
This may be; I'll leave that decision to you as the interface designer.
On Thu, 09 Sep 2004 11:49:33 -0700, William Lee Irwin III wrote: >> I'm not aware of a discrepancy with the fs/proc/task_nommu.c code; I >> did, however, have to mangle the things via guesswork to avoid adding >> the new fields, which I really wanted you to arrange for or comment on >> as they are a matter of interface. Also, could you be more specific >> about these discrepancies?
On Thu, Sep 09, 2004 at 09:11:42PM +0200, Roger Luethi wrote: > task_nommu.c offers Mem, Slack, and Shared. __task_mem for !CONFIG_MMU > offers VmData, VmStack, VmRSS, VmSize.
I took the structure fields to be just an argument passing convention giving the nommu case an identical prototype much like the helpers in fs/proc/task_{no,}mmu.c. Using different field names and etc. is also feasible, of course. I'll wait for your updates to follow up further.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |