Messages in this thread | | | Date | Thu, 9 Sep 2004 11:32:16 -0400 (EDT) | From | Zwane Mwaikambo <> | Subject | Re: [PATCH][5/8] Arch agnostic completely out of line locks / ppc64 |
| |
On Thu, 9 Sep 2004, Linus Torvalds wrote:
> On Thu, 9 Sep 2004, Linus Torvalds wrote: > > > > and the fact is, this is all much better just done in the arch-specific > > spinlock code. > > This is especially true since some architectures may have high overheads > for this, so you may do normal spinning for a while before you even start > doing the "fancy" stuff. So there is no ay we should expose this as a > "generic" interface. It ain't generic. It's very much a low-level > implementation detail of "spin_lock()".
Agreed, Paul we may as well remove the cpu_relax() in __preempt_spin_lock and use something like "cpu_yield" (architectures not supporting it would just call cpu_relax) i'll have something for you later.
Thanks, Zwane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |