Messages in this thread | | | Subject | Re: [PATCH] Use msleep_interruptible for therm_adt7467.c kernel thread | From | Benjamin Herrenschmidt <> | Date | Wed, 29 Sep 2004 14:13:14 +1000 |
| |
On Wed, 2004-09-29 at 11:58, Herbert Xu wrote: > On Mon, Sep 27, 2004 at 01:51:42PM +0100, Alan Cox wrote: > > On Llu, 2004-09-27 at 11:25, Herbert Xu wrote: > > > The continue is just paranoia in case something relies on the sleep > > > to take 2 seconds or more. > > > > If the signal occurs then you'll spin for 2 seconds because the signal > > is still waiting to be serviced. This therefore looks broken > > Yes you're right. However I'd say that msleep_interruptible should > mirror the behaviour of schedule_timeout and at least sleep once.
Mask all signals then, there is no need to get any signal in that kernel thread anyway
> BTW, msleep_interruptible() is white-space damaged. Can someone please > fix it up? > > > A more interesting question is why this isn't being driven off a > > timer ? > > It probably could if the stuff afterwards doesn't sleep. > > Cheers, -- Benjamin Herrenschmidt <benh@kernel.crashing.org>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |