Messages in this thread | | | Date | Mon, 20 Sep 2004 08:44:13 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: page fault scalability patch V8: [7/7] atomic pte operations for s390 |
| |
On Sun, 19 Sep 2004, Denis Vlasenko wrote:
> On Sunday 19 September 2004 02:31, Christoph Lameter wrote: > > +static inline int > > +pmd_test_and_populate(struct mm_struct *mm, pmd_t *pmd, struct page *page) > > +{ > > + int rc; > > + spin_lock(&mm->page_table_lock); > > + > > + rc=pte_same(*pmd, _PAGE_INVALID_EMPTY); > > + if (rc) pmd_populate(mm, pmd, page); > > + spin_unlock(&mm->page_table_lock); > > + return rc; > > +} > > Considering that spin_lock and spin_unlock are inline functions, > this function may end up being large. > > I didn't see a single non-inlined function in these patches yet. > Please think about code size.
This function is only used once.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |