lkml.org 
[lkml]   [2004]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: hotplug e1000 failed after 32 times

All this work and code for such an uncommon case??

First off, any settings which are _indexed_ are almost guaranteed
broken. For reasons as we see here, and others. Any
"setting_foo[board_number]" should be found and eliminated instead.

Even if you allocate and free board numbers as described, how precisely
do you propose to predict which settings belong to which hotplugged
board? Look at the problem, and you realize that the board<->setting
association becomes effectively _random_ for any adapter not present at
modprobe time.

The best model is to set these settings via netlink/ethtool after
registering the interface, but before bringing it up.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.080 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site