lkml.org 
[lkml]   [2004]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Masking kernel commandline parameters (2.6.7)
Date
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> That would make that ugly kernel patch pointless, wouldn't it? Then
> why bother with it?

Also, what aspects of it do you consider ugly? -I didn't see any better way of
implementing this feature. No, I don't like the fact that I am mangling the
command_line and saved_command_line arrays directly, but I wanted to reuse as
many constructs of the kernel as possible - and that means doing just that.

The only other aspect I see that isn't real nice is the re-setting of the
quotation mark, which was replaced with a \0 by the parse_args function -
this requires access to a negative array index... Also note that I placed
special emphasis on not providing opportunity for buffer overflows or other
boundary issues.

Please elaborate on your thoughts, if there is a better way of implementing
this, I'll surely adapt my work.

jp

ps: in case you're referring to the feature itself, what would be a more
sensible way of passing sensitive data to the kernel? -I didn't see any other
way.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBFhz5z6J7R+QJGuwRAqZDAJ46UglAXcpeuX/NjZSz5LSTVvhXqQCfbyBx
5tbm+DsRfhZudqWEPXHWIPA=
=Tv5d
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:5.046 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site