lkml.org 
[lkml]   [2004]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cdrom: MO-drive open write fix (trivial)
On Fri, Aug 06 2004, Andrew Morton wrote:
> Stefan Meyknecht <sm0407@nurfuerspam.de> wrote:
> >
> > [PATCH] cdrom: MO-drive open write fix
> >
> > Allow mounting mo-drives readwrite.
> >
> > Please apply.
> >
> > Stefan
> >
> >
> > --- linux/drivers/cdrom/cdrom.c.orig 2004-08-06 18:04:16.269803330 +0200
> > +++ linux/drivers/cdrom/cdrom.c 2004-08-06 18:04:33.570828588 +0200
> > @@ -899,7 +899,7 @@ int cdrom_open(struct cdrom_device_info
> > ret = -EROFS;
> > if (cdrom_open_write(cdi))
> > goto err;
> > - if (!CDROM_CAN(CDC_RAM))
> > + if (!CDROM_CAN(CDC_RAM) && !CDROM_CAN(CDC_MO_DRIVE))
> > goto err;
> > ret = 0;
> > }
>
> I forwarded this to Jens last time you sent it and he said "Not really,
> CDC_RAM is an umbrella that should already cover these devices. I'll reply
> to him."
>
> So... could you describe the actual bug which you're seeing - maybe
> there's some different fix which we need.

Sorry, guess I forgot to reply on linux-kernel. What I mean is that MO
drives should just have CDC_RAM set - it doesn't denote a specific
device type, rather just the ability to work like a hard drive. If you
could look into why that isn't set for your mo device and send a patch
for that, it would be much better.

Jens

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.034 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site