Messages in this thread | | | Date | Fri, 6 Aug 2004 12:46:09 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] VFS readahead bug in 2.6.8-rc[1-3] |
| |
Phillip Lougher <phillip@lougher.demon.co.uk> wrote: > > Nick Piggin wrote: > > > No, I suggest you start to code assuming this interface does > > what it does. I didn't say there is no bug here, but nobody > > else's filesystem breaks. > > > > To stop this silly argument from escalating, I will patch my code. >
Well I don't think it's silly.
We are deterministically asking the fs to read a page which lies outside EOF, and we shouldn't. If for no other reason than that the ever-popular "read a million 4k files" workload will consume extra CPU and twice the pagecache.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |