Messages in this thread | | | Date | Thu, 19 Aug 2004 16:00:08 -0700 (PDT) | From | Jon Smirl <> | Subject | Re: [PATCH] add PCI ROMs to sysfs |
| |
--- Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > On Mer, 2004-08-18 at 19:13, Jon Smirl wrote: > > I haven't received any comments on pci-sysfs-rom-17.patch. Is > > everyone asleep or is it ready to be pushed upstream? I'm still > > not sure that anyone has tried it on a ppc machine. > > Looks ok to me. Not sure we ever want to copy roms kernel side but > thats a minor query only. >
Drivers for hardware with partial PCI decoding need to at least add a call to pci_remove_rom() to remove the rom attribute from sysfs. I don't know which hardware has this problem or even if any hardware with a Linux driver has this problem. If anyone is maintainer for a driver like this, please let me know and I can add the call to pci_remove_rom().
Also, I believe the i386 quirk should also be applied to the x86_64 arch. I don't have the hardware and I don't know enough about the boot aequence in 64 bits to do the right thing with a guess. The code is not broken for x86_64, it just may not pick up the right ROM image on that architecture.
===== Jon Smirl jonsmirl@yahoo.com
__________________________________ Do you Yahoo!? Yahoo! Mail - 50x more storage than other providers! http://promotions.yahoo.com/new_mail - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |