Messages in this thread | | | Date | Sat, 14 Aug 2004 15:32:47 -0400 (EDT) | From | James Morris <> | Subject | Re: [PATCH][LIBFS] Move transaction file ops into libfs + cleanup (update) |
| |
On Sat, 14 Aug 2004, Francois Romieu wrote:
> > +static inline void simple_transaction_set(struct file *file, size_t n) > > +{ > > + struct simple_transaction_argresp *ar = file->private_data; > > + > > + BUG_ON(n > SIMPLE_TRANSACTION_LIMIT); > > + mb(); > > + ar->size = n; > > +} > > Could you add the justification for the 'mb' (or the expected effect on the > api) as a comment ?
This ensures that ar->size will really remain zero until ar->data is ready for reading.
- James -- James Morris <jmorris@redhat.com>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |