Messages in this thread | | | Date | Wed, 28 Jul 2004 14:45:47 -0700 | From | Ben Greear <> | Subject | Re: PATCH: VLAN support for 3c59x/3c90x |
| |
Andrew Morton wrote: > Alan Cox <alan@redhat.com> wrote: > >>This adds VLAN support to the 3c59x/90x series hardware. > > > Sigh. This has been floating about for ever. My reluctance stemmed > from largely-theoretical-sounding objections from Don Becker which I > didn't fully understand at the time and have now forgotten. > > Ben, does the patch look complete/correct to you?
I don't have such hardware, but I don't see any obvious problems with the patch.
In my opinion Becker's complaints were invalid, or maybe I just didn't understand what he was trying to say. At any rate, lots of other NICs have supported larger MTUs and VLANs w/out problem, so it is unlikely that there is a fundamental flaw in accepting larger frames.
There are patches for tulip floating around too. I have been running traffic on these patches for a while with no obvious problems (on 2.4 kernel, however). Jeff, if you want me to re-send this to you, please let me know!
Ben
-- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |