Messages in this thread | ![/](/images/icornerl.gif) | | From | Jesse Barnes <> | Subject | Re: [Lse-tech] [RFC][PATCH] Change pcibus_to_cpumask() to pcibus_to_node() | Date | Tue, 27 Jul 2004 11:40:29 -0700 |
| |
On Tuesday, July 27, 2004 11:32 am, Matthew Dobson wrote: > > ... > > #ifdef CONFIG_NUMA > > int node; /* or nodemask_t if necessary */ > > #endif > > ... > > > > to struct pci_bus instead? That would make the existing code paths a > > little faster and avoid the need for a global array, which tends to lead > > to TLB misses. > > I like that idea! Stick a nodemask_t in struct pci_bus, initialize it > to NODE_MASK_ALL. If a particular arch wants to put something more > accurate in there, then great, if not, we're just in the same boat we're > in now.
Cool, sounds like that'll work well.
> I'm trying to keep the dependency of topology on what the pci_dev and > pci_bus structs look like to a minimum. That's why I'd like to keep the > topology function based on PCI bus numbers (or possibly struct pci_bus), > not struct pci_dev. The pci_bus is what really has the node affinity > anyway, and the device only has that affinity through the fact that it > is physically plugged into a particular bus.
Sure, that make sense. And it's easy enough to get a pci_bus from a pci_dev that we probably won't run into trouble.
Thanks, Jesse - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |