lkml.org 
[lkml]   [2004]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: serious performance regression due to NX patch
>>>>> On Tue, 13 Jul 2004 09:05:29 -0700, Mark Haverkamp <markh@osdl.org> said:

Mark> I think that there is a problem with this piece of code in
Mark> binfmt_elf.c:

Mark> if (i == elf_ex.e_phnum)
Mark> def_flags |= VM_EXEC | VM_MAYEXEC;

I think there are other problems, too:

- any fork() will reset mm->def_flags to zero so if you exec
an old binary and it does a fork, future mmaps() won't
have the execute-bit turned on any more; perhaps a rare problem,
but it certainly seems an illogical behavior

- likewise for do_mlockall(): it stomps on def_flags without preserving
the old bits

Am I missing something?

--david
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.069 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site