Messages in this thread | | | Date | Mon, 7 Jun 2004 15:39:19 -0700 | From | Greg KH <> | Subject | Re: small patch: enable pwc usb camera driver |
| |
On Tue, Jun 08, 2004 at 12:27:04AM +0200, Nemosoft Unv. wrote: > On Monday 07 June 2004 22:20, Greg KH wrote: > > On Mon, Jun 07, 2004 at 03:00:43PM +0200, Kai Engert wrote: > > > The attached patch enables the pwc driver included with kernel > > > 2.6.7-rc2 > > > > > > It also removes the warnings during compilation. > > > However, note that I blindly duplicated the release approach used by > > > other usb camera drivers, replacing the current no-op. > > > > > > The driver works for me with a Logitech QuickCam Notebook Pro and > > > GnomeMeeting. > > > > Nice, thanks, I've applied this. > > Don't use this. It will BUG() your kernel hard, because of a double free().
Oops, oh well, the pwc driver is really messed up then... I already sent this to Linus, and as no one has fixed this issue up in a long time, I'll wait for someone to send another patch fixing this one as it's obvious that this driver does not have many users :(
> > It's amazing how long it took for this to be fixed... :( > > I could start a big *bleep*ing rant about this, but I?ll save that for some > other time.
Heh, we've discussed this already in private, I'll be glad to discuss it again, any time, in public on any mailing list.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |