Messages in this thread | | | Date | Sun, 6 Jun 2004 14:11:57 +0200 (CEST) | From | Pascal Schmidt <> | Subject | Re: [OT] Who has record no. of DriveReady SeekComplete DataRequest errors? |
| |
On Sun, 6 Jun 2004, Jens Axboe wrote:
> Interesting, and 2.6.2 works flawlessly? The only change in 2.6.3 wrt > ide-cd is the addition of the != 2kB sector size support from Pascal > Schmidt. A quick guess would be that blocklen isn't set, does this > change anything for you?
Hmmm, another thing that just occured to me is that maybe some broken drive might return the raw sector size, despite what the standard says.
> ===== drivers/ide/ide-cd.c 1.83 vs edited ===== > --- 1.83/drivers/ide/ide-cd.c 2004-05-29 19:04:42 +02:00 > +++ edited/drivers/ide/ide-cd.c 2004-06-06 11:27:51 +02:00 > @@ -2205,6 +2205,8 @@ > *capacity = 1 + be32_to_cpu(capbuf.lba); > *sectors_per_frame = > be32_to_cpu(capbuf.blocklen) >> SECTOR_BITS; > + if (*sectors_per_frame == 0) > + *sectors_per_frame = SECTORS_PER_FRAME; > } > > return stat;
If this turns out to be the cause, maybe we should check that blocklen isn't 0 and divisible by 512.
-- Ciao, Pascal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |