Messages in this thread | | | From | Andreas Gruenbacher <> | Subject | Re: RFC: Testing for kernel features in external modules | Date | Fri, 25 Jun 2004 10:32:22 +0200 |
| |
On Thursday 24 June 2004 22:35, Andreas Dilger wrote: > Ideally, when people make an incompatible kernel API change like this > they would just #define HAVE_REMAP_PAGE_RANGE_VMA in the header that > declares remap_page_range() directly (e.g. KERNEL_AS_O_DIRECT was added > for this reason) instead of external builds having to figure this out > themselves. Adding the check script is no less work than just adding > the #define to the appropriate header directly.
I disagree. I don't think we want to clutter the code with feature definitions that have no known users. That doesn't age/scale very well. It's easy enough to test for features in the external module.
Cheers, -- Andreas Gruenbacher <agruen@suse.de> SUSE Labs, SUSE LINUX AG - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |