Messages in this thread | | | Date | Mon, 14 Jun 2004 10:58:35 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] IDE update for 2.6.7-rc3 [1/12] |
| |
On Sun, Jun 13, 2004 at 07:36:08PM +0200, Bartlomiej Zolnierkiewicz wrote: > > IMHO the PCI ->probe methods should always be __devinit. It's rather > > hard to make sure they're never every hotplugged in any way, especially > > with the dynamic id adding via sysfs thing. > > I generally agree but IMO it makes no sense for i.e. piix.c.
Are you sure? I've seen piix3/4 in very strange place, iirc even in a docking station which is hotpluggable.
And even if for this special hardware it's usually not doable there are things like greg's fake hotplug pci driver. So a non-__devinit pci probe method is a bug, please fix them in PCI. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |