Messages in this thread | | | Date | Fri, 7 May 2004 11:21:52 -0400 (EDT) | From | James Morris <> | Subject | Re: [PATCH][SELINUX] 2/2 sock_create_lite() |
| |
On Fri, 7 May 2004, Christoph Hellwig wrote:
> On Fri, May 07, 2004 at 11:06:04AM -0400, James Morris wrote: > > This patch adds a function sock_create_lite(), deprecating kernel-wide use > > of sock_alloc(), which has been made static to net/socket.c. > > We're in the stable series and removing exported APIs there shoudn't happen. > Given that sock_alloc() is actually okay for every normal use I don't think > there's enough reason to remove it from the API.
Fair enough.
> > +int sock_create_lite(int family, int type, int protocol, struct socket **res) > > Should probably be called __sock_create according to linux naming rules. > Also I guess you should actually call it from sock_create instead of > duplicating the code.
sock_create() is really very different to sock_alloc(), and the only real duplication is calling the LSM hooks. The version I sent seems to be the simplest approach.
(note that __sock_create() is already created in the previous patch).
- James -- James Morris <jmorris@redhat.com>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |