lkml.org 
[lkml]   [2004]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux 2.6.7-rc2
Peter Osterlund <petero2@telia.com> wrote:
>
> If I put "#if 0" around the *wdata assignment in nfs_writepage_sync,
> the stack usage goes down to 36, so it looks like gcc is building a
> temporary structure on the stack and then copies the whole thing to
> *wdata.

aww, crap.

> Does this construct save stack space for any version of gcc? Maybe the
> code should be changed to do a memset() followed by explicit
> initialization of the non-zero member variables instead.

yes, we should do that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.279 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site