Messages in this thread | | | Date | Sat, 29 May 2004 23:42:58 -0700 | From | "David S. Miller" <> | Subject | Re: [PATCH] Fix typo in pmac_zilog |
| |
On Fri, 28 May 2004 13:40:55 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> This patch fixes a typo preventing channel B from working on the Rx > path of pmac zilog (never calling tty_flip_*). I think I never tested > channel B :)
Ben, why do you do the tty_flip_buffer_push() outside of the port lock? Just because it's expensive and therefore this decreases the lock hold time, or is there some deadlock issue?
Sounds like I should make the change to sunzilog :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |