lkml.org 
[lkml]   [2004]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: scheduler: IRQs disabled over context switches

* Nick Piggin <nickpiggin@yahoo.com.au> wrote:

> >+# define prepare_arch_switch(rq, next) \
> >+ do { \
> >+ spin_lock(&(next)->switch_lock); \
> >+ spin_unlock(&(rq)->lock); \
>
> spin_unlock_irq?

and spin_unlock in the finish_arch_switch() case, instead of
spin_unlock_irq. New patch below.

Ingo

--- linux/kernel/sched.c.orig
+++ linux/kernel/sched.c
@@ -247,9 +247,15 @@ static DEFINE_PER_CPU(struct runqueue, r
* Default context-switch locking:
*/
#ifndef prepare_arch_switch
-# define prepare_arch_switch(rq, next) do { } while (0)
-# define finish_arch_switch(rq, next) spin_unlock_irq(&(rq)->lock)
-# define task_running(rq, p) ((rq)->curr == (p))
+# define prepare_arch_switch(rq, next) \
+ do { \
+ spin_lock(&(next)->switch_lock); \
+ spin_unlock_irq(&(rq)->lock); \
+ } while (0)
+# define finish_arch_switch(rq, prev) \
+ spin_unlock(&(prev)->switch_lock)
+# define task_running(rq, p) \
+ ((rq)->curr == (p) || spin_is_locked(&(p)->switch_lock))
#endif

/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.039 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site