Messages in this thread | | | Date | Mon, 24 May 2004 13:43:14 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] msync shouldn't go over bss sections |
| |
Alexander Nyberg <alexn@telia.com> wrote: > > This changes the behaviour of msync_interval() to make it impossible to > try to sys_msync() anything not file mapped. >
Well the patch doesn't "make it impossible". It makes it return -ENOMEM.
From my reading of the spec your patch converts correct behaviour to incorrect behaviour, and even if that's untrue, I think we're stuck with the current behaviour - this change can break current applications.
> --- mm/msync_orig.c 2004-05-23 21:31:32.000000000 +0200 > +++ mm/msync.c 2004-05-24 16:10:24.000000000 +0200 > @@ -137,7 +137,7 @@ static int filemap_sync(struct vm_area_s > static int msync_interval(struct vm_area_struct * vma, > unsigned long start, unsigned long end, int flags) > { > - int ret = 0; > + int ret = -ENOMEM; > struct file * file = vma->vm_file; > > if ((flags & MS_INVALIDATE) && (vma->vm_flags & VM_LOCKED)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |