Messages in this thread | | | Date | Wed, 12 May 2004 16:24:53 -0400 | From | Jeff Garzik <> | Subject | Re: MSEC_TO_JIFFIES is messed up... |
| |
Andrew Morton wrote: > Yes, that's a correct optimisation. This is simply a namespace clash.
Agreed.
> How about we do: > > #if HZ=1000 > #define MSEC_TO_JIFFIES(msec) (msec) > #define JIFFIES_TO_MESC(jiffies) (jiffies) > #elif HZ=100 > #define MSEC_TO_JIFFIES(msec) (msec * 10) > #define JIFFIES_TO_MESC(jiffies) (jiffies / 10) > #else > #define MSEC_TO_JIFFIES(msec) ((HZ * (msec) + 999) / 1000) > #define JIFFIES_TO_MSEC(jiffies) ... > #endif > > in some kernel-wide header then kill off all the private implementations?
include/linux/time.h. One of the SCTP people already did this, but I suppose it's straightforward to reproduce.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |